Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove bad files & obsolete commands ci skip:syst #78

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Fix: remove bad files & obsolete commands ci skip:syst #78

merged 8 commits into from
Nov 9, 2023

Conversation

Ming-Yan
Copy link
Collaborator

@Ming-Yan Ming-Yan commented Oct 24, 2023 •
edited by uttiyasarkar
Loading

fixes

  • metadata : remove bad files and change prefix, correct the key name
  • condor: remove obsolete commands in submission scripts, add skipbadfile( make the array copy options only exist for analysis)
  • BTA: fix gen index issue and add weight info metadata

Updates

  • runner: dedicated directory for array/hist output
  • data & utils: add JP calibration files for 2022CD & Summer22
  • utils: restructure new tagger info & definition
  • helper: add xsecton info (and corrected cross section from @demuller, need script for automatically fetch xsection info easier #73 )
  • scripts: add file check scripts to in fetch.py
  • scripts: plot & readme: set default CM =13.6TeV, add mergemap option in comparison(remove shortref/shortcom instead of mergemap keyname)
  • ci: only triggered when changes in the workflow/framework, use commit messages to configured running options
  • xsection.py updated with the latest xsection info collected. 13 TeV xsection are stashed into a separate file. Requires further update in future

@Ming-Yan
fix : remove bad files & add cross-sections
3fa956f 
- metadata:remove bad files
- scripts: implement remove bad files in fetch.py script
- plot: fix wrong axis defintion & add new variables definitions
- helpers: update xsections
- wf: add pv info & weight info in BTA_ttbar_wf
@Ming-Yan
feat: add features for plotting scripts
7c5005d
@Ming-Yan
Merge branch 'div' into btv_upstream
1282411 
Conflicts:
	metadata/test_bta_run3.json
@Ming-Yan Ming-Yan self-assigned this Oct 24, 2023
@github-actions github-actions bot added the CI label Oct 27, 2023
@Ming-Yan Ming-Yan changed the title Fix: remove bad files & obsolete commands [run array] Fix: remove bad files & obsolete commands Nov 1, 2023
@Ming-Yan Ming-Yan force-pushed the btv_upstream branch 5 times, most recently from 50a21cd to 1d8e6c3 Compare November 7, 2023 22:30
Ming-Yan and others added 2 commits November 8, 2023 12:58
@Ming-Yan
[run array] ci: customize ci , fix bugs in workflow
b8253eb 
- ci: only trigger if changes
- doc,ci: add customize commit message to run ci
- wf: fix dtype bug
@mondalspandan @Ming-Yan
fix : add nested directory for output & fix fetch printout messages
f289458 
- condor,runner: add nested directory
- runner: add other options for only
- script: change fetch messages
@github-actions github-actions bot added the runner label Nov 8, 2023
@Ming-Yan
fix: change default ci, minor bugs ci:skip syst
f0b6337 
- helper: fix bug for missing DeepB case
- ci, doc: reoptimize default ci options
- condor: fix copy commands
@Ming-Yan Ming-Yan changed the title [run array] Fix: remove bad files & obsolete commands Fix: remove bad files & obsolete commands skip:syst Nov 8, 2023
@uttiyasarkar @Ming-Yan
fix: Update xsection.py
65b4e7b 
- remove 13TeV xsection
- Changes made to the xsec in consistent to BTV private google sheeet:
https://docs.google.com/spreadsheets/d/1WUwRG6b6iiPSUr-bDyLjSA4JW8ePdsY3Q55J7gSq4gc/edit
@Ming-Yan Ming-Yan changed the title Fix: remove bad files & obsolete commands skip:syst Fix: remove bad files & obsolete commands ci skip:syst Nov 9, 2023
@uttiyasarkar
Copy link
Collaborator

uttiyasarkar commented Nov 9, 2023 •
edited
Loading

Testing:

  • Runs smoothly over 2022 Summer PreEE era
  • Run2022E, JEC mising. Runs without JEC for 2022E, and 2022F, 2022G with JEC
  • CI integration: failures due to missing PU uncertainties

Missing features:

  • PU uncertainties
  • 2022E JEC
  • xsection, almost accurate
  • script for fetching xsection automatically from GenXSecAnalyzer

@uttiyasarkar uttiyasarkar reopened this Nov 9, 2023
@uttiyasarkar uttiyasarkar merged commit 9bb6e48 into cms-btv-pog:master Nov 9, 2023
4 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uttiyasarkar uttiyasarkar Awaiting requested review from uttiyasarkar

@demuller demuller Awaiting requested review from demuller

Assignees

@Ming-Yan Ming-Yan

Labels
CI runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ming-Yan @uttiyasarkar @mondalspandan